Use CRT for releases and CI #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release version is specified when manually triggering the build workflow. Go version is determined using the .go-version file. Will build for arm, arm64, 386, and amd64 now instead of just amd64.
tomhjp
reviewed
Mar 23, 2022
.release/ci.hcl
Outdated
| github { | ||
| organization = "hashicorp" | ||
| repository = "vault-lambda-extension" | ||
| release_branches = ["main", "VAULT-5260/use-crt"] |
There was a problem hiding this comment.
Leaving a comment as a reminder we should remove the test branch before merging.
and only build for arm64 and amd64
tomhjp
approved these changes
Apr 6, 2022
|
Tested both arm64 and amd64 binaries, and they seem to work, so I think we're good here 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release version is specified when manually triggering the build workflow. Go version is determined using the .go-version file. Will build for arm64 as well as amd64.
TODO:
[ ] Setup AWS layer releases in a GitHub workflow(this will be done in another repo)