Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recognize ed25519 key type and return PKCS8 format #13257

Merged
merged 3 commits into from
Nov 24, 2021
Merged

recognize ed25519 key type and return PKCS8 format #13257

merged 3 commits into from
Nov 24, 2021

Conversation

navaneethrameshan
Copy link
Contributor

Addresses #13256

convertRespToPKCS8 does not recognize the ed25519 key. Changes
to recognize ed25519 key and return its PKCS8 format

@navaneethrameshan
return pkcs8 format for ed25519 curve
8cd78d8 
convertRespToPKCS8 does not recognize the ed25519 key. Changes
to recognize ed25519 key and return its PKCS8 format
@vercel vercel bot temporarily deployed to Preview – vault November 23, 2021 19:11 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook November 23, 2021 19:11 Inactive
@vercel vercel bot temporarily deployed to Preview – vault November 23, 2021 19:13 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook November 23, 2021 19:13 Inactive
@navaneethrameshan
Copy link
Contributor Author

navaneethrameshan commented Nov 23, 2021 •
edited
Loading

Requires #13254 as a base to verify and validate this PR

@stevendpclark stevendpclark added this to the 1.9.1 milestone Nov 24, 2021
stevendpclark
stevendpclark requested changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@stevendpclark stevendpclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, much appreciated @navaneethrameshan for the second fix in this area!

Could I ask that you rename the changelog file adding a .txt to the filename please?

@vercel vercel bot temporarily deployed to Preview – vault November 24, 2021 18:47 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook November 24, 2021 18:47 Inactive
@navaneethrameshan
Copy link
Contributor Author

Thank you @stevendpclark! Updated the changelog file name.

@stevendpclark stevendpclark merged commit 50a9c8a into hashicorp:main Nov 24, 2021
stevendpclark pushed a commit that referenced this pull request Nov 24, 2021
@navaneethrameshan @stevendpclark
recognize ed25519 key type and return PKCS8 format (#13257)
d776122 
* return pkcs8 format for ed25519 curve

convertRespToPKCS8 does not recognize the ed25519 key. Changes
to recognize ed25519 key and return its PKCS8 format
@stevendpclark stevendpclark mentioned this pull request Nov 24, 2021
Merged
stevendpclark added a commit that referenced this pull request Nov 24, 2021
@stevendpclark @navaneethrameshan
recognize ed25519 key type and return PKCS8 format (#13257) (#13276)
7946efe 
* return pkcs8 format for ed25519 curve

convertRespToPKCS8 does not recognize the ed25519 key. Changes
to recognize ed25519 key and return its PKCS8 format

Co-authored-by: Navaneeth Rameshan <vme@zurich.ibm.com>
@thiskevinwang thiskevinwang mentioned this pull request Apr 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevendpclark stevendpclark stevendpclark approved these changes

Assignees
No one assigned
Labels
secret/pki
Projects
None yet
Milestone
1.9.1
Development

Successfully merging this pull request may close these issues.
2 participants
@navaneethrameshan @stevendpclark