-
Notifications
You must be signed in to change notification settings - Fork 79
Adding vault content inclusion exclusions #962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
williamdalessandro
wants to merge
38
commits into
main
Choose a base branch
from
adding-vault-content-inclusion-exclusions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
28d83ef
first pass for vault exclusions
williamdalessandro bf00207
added in functionality to have the exclusion work and play nice with …
williamdalessandro 8029005
adding in manual test case to see if vault exclusion is actually working
williamdalessandro f826f97
added test case to terraform exclusion
williamdalessandro 7a5924d
added in test suite for vault exclusions- currently failing
williamdalessandro ca1e6f4
Merge branch 'main' into adding-vault-content-inclusion-exclusions
williamdalessandro bd5f9b6
fixing tests, 2 more left
williamdalessandro 1770d45
final test fixes, removing some comments
williamdalessandro 60818e9
Merge branch 'main' into adding-vault-content-inclusion-exclusions
williamdalessandro e174739
adding in new compiled binaries since these are changes in the script…
williamdalessandro 71ef912
updating the single file transform to include vault exclusions
williamdalessandro c55f4c4
Merge branch 'main' into adding-vault-content-inclusion-exclusions
williamdalessandro 51b0a7d
slight comment change
williamdalessandro f321df5
adding latest binaries
williamdalessandro a0008ca
adding shared mjs file
williamdalessandro 550b5c4
added revelant comment to shared.mjs, renamed VLT to vault
williamdalessandro 76eb25a
forgot to add copyright header
williamdalessandro d2611de
Move config to productConfig
RubenSandwich 8516798
Refactor version test code
RubenSandwich e115082
it's time to walk away
RubenSandwich 04434cb
small changes
williamdalessandro 80e1740
adding reducing code duplication and added readme explainer
williamdalessandro c3c0efa
adding in integration with existing code
williamdalessandro 1d636f6
current binaries for build to reflect latest changes
williamdalessandro 7e23f2d
initial changes for unified approach
williamdalessandro 8371a05
massive structural change, turned shared functionality into shared ut…
williamdalessandro c5c2bb4
adding in individual file transform support
williamdalessandro 8a563bb
merging changes back to primary branch
williamdalessandro c4692d1
staying consistent until the order should be properly changed
williamdalessandro 4746560
removing older approach
williamdalessandro 09fe52f
adding simple change to content exclusion
williamdalessandro a481a98
adding in change to do partials first and skip global partials
williamdalessandro 2bd33e6
adding in two extra tests for exclude content to try to catch parsing…
williamdalessandro 33634e8
adding in entire testing suite for mdx transforms to test against thi…
williamdalessandro 3e92a7f
fixing bug caught by tests during global partials- certain partials w…
williamdalessandro d5c21df
update readme
williamdalessandro d32ac47
adding in global partial support for single file transform
williamdalessandro 85a51fa
change formatting in mdx transform test, added in more test for edge …
williamdalessandro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
content/vault/v1.20.x/content/docs/concepts/client-count/test-vault-exclusion.mdx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
--- | ||
page_title: Test Vault Content Exclusion yoo | ||
--- | ||
|
||
# Test Vault Content Exclusion | ||
|
||
This content should always appear. | ||
|
||
<!-- BEGIN: Vault:>=v1.21.x --> | ||
This content should be REMOVED because current version (1.20.x) is less than 1.21.x | ||
<!-- END: Vault:>=v1.21.x --> | ||
|
||
<!-- BEGIN: Vault:<=v1.21.x --> | ||
This content should STAY because current version (1.20.x) is less than or equal to 1.21.x | ||
<!-- END: Vault:<=v1.21.x --> | ||
|
||
<!-- BEGIN: Vault:=v1.20.x --> | ||
This content should STAY because current version equals 1.20.x | ||
<!-- END: Vault:=v1.20.x --> | ||
|
||
<!-- BEGIN: Vault:<v1.19.x --> | ||
This content shofuld be REMOVED because current version (1.20.x) is not less than 1.19.x | ||
<!-- END: Vault:<v1.19.x --> | ||
|
||
Final content that should always appear. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@williamdalessandro are we sure about this? It sounds like they want content exclusion in global partials: https://app.asana.com/1/90955849329269/task/1211058606978186/comment/1211471674451585?focus=true.
Double check with Sarah here; as I am not 100% sure on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's ask Sarah for a test case here, so we can double check that we understand their needs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything else in this PR looks great. 🎉
We just need to double check this before approval.