error-stack: remove leading space for multiline attachments
#2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/libs > error-stack
Codecov Report
@@ Coverage Diff @@
## main #2022 +/- ##
=======================================
Coverage 56.14% 56.14%
=======================================
Files 270 270
Lines 19574 19574
Branches 421 421
=======================================
Hits 10990 10990
Misses 8579 8579
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
TimDiekmann
approved these changes
Feb 8, 2023
|
/trunk merge |
|
😎 Merged successfully (details). |
trunk-io bot
pushed a commit
that referenced
this pull request
Feb 8, 2023
## 🌟 What is the purpose of this PR? A small bug was highlighted in #2019 and fixed in #2022, so we want to publish the fix. ## 🔗 Related links - Closes #2019 - #2022 ##⚠️ Known issues Currently, the `SemVer Check` job is disabled, so we have to run it manually. Output: ``` ❯ cargo semver-checks check-release Updating index Parsing error-stack v0.3.1 (current) Parsing error-stack v0.3.0 (baseline) Checking error-stack v0.3.0 -> v0.3.1 (minor change) Completed [ 0.127s] 35 checks; 35 passed, 5 unnecessary cargo semver-checks check-release 11.95s user 2.40s system 87% cpu 16.334 total ❯ echo $? 0 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌟 What is the purpose of this PR?
This was an oversight in #1980, where we removed the leading space from attachments but forgot multiline attachments.
🔗 Related links