GEN-37: Combine IntoReport and ResultExt
#2883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/libs > error-stack
TimDiekmann
changed the title
IntoReport and ResultExtIntoReport and ResultExt
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2883 +/- ##
==========================================
- Coverage 51.63% 51.55% -0.09%
==========================================
Files 337 337
Lines 28971 29022 +51
Branches 433 433
==========================================
+ Hits 14960 14963 +3
- Misses 14009 14057 +48
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
github-actions
bot
added
the
area/infra
vilkinsons
changed the title
IntoReport and ResultExtIntoReport and ResultExt
indietyp
requested changes
Aug 9, 2023
Co-authored-by: Bilal Mahmoud <bmahmoud@mpi-cbg.de>
|
Also: We still need a changelog entry! |
Co-authored-by: Bilal Mahmoud <bmahmoud@mpi-cbg.de>
indietyp
previously approved these changes
Aug 9, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
indietyp
approved these changes
Aug 10, 2023
TimDiekmann
deleted the
td/gen-37-allow-change_context-to-call-into_report
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌟 What is the purpose of this PR?
After a lot of back and forth and various discussions (internally and on GitHub and other public platforms), we decided to merge the functionality of
IntoReportintoResultExt.🔗 Related links
change_contextto callinto_report#1968🔍 What does this change?
ResultExtby atype Context: Contextassociated type (technically a breaking change likely has no impact) - requires a minor version bumpResultExtforcore::result::Result<T, C> where C: ContextPre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR:
IntoReportCompatbut due to the Orphan rule it's not possible to implementResultExtoneyreoranyhowerrors.