Dap estgi work #14
Merged
Dap estgi work #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
csabahruska
commented
Jul 5, 2023
csabahruska
commented
- Fix package.json type attribute
- VSCode templates default to .ghc_stgapp
- Factor out the dap library from the estg-dap server executable
…'launch.json' template
…as input and create fullpak from it at init
dmjio
reviewed
Jul 5, 2023
dap-estgi-server/src/Main.hs
Outdated
| moduleInfos <- liftIO $ getModuleListFromFullPak program | ||
| ghcstgappPath <- liftIO $ findProgram program >>= \case | ||
| [fname] -> pure fname | ||
| names -> fail $ "ambiguous program path, multiple matches: " ++ show names |
There was a problem hiding this comment.
Potentially need to handle the empty match [] case.
There was a problem hiding this comment.
Consider using sendError as opposed to fail
dmjio
reviewed
Jul 5, 2023
| # dap-extension README | ||
|
|
||
| This is the README for your extension "dap-extension". After writing up a brief description, we recommend including the following sections. | ||
| This is the README for your extension "dap-estgi-extension". After writing up a brief description, we recommend including the following sections. |
There was a problem hiding this comment.
Might need to continue this renaming in a few more places:
dap-estgi-server/src/Main.hs
120:-- > "type": "dap-extension"
dap-estgi-vscode-extension/CHANGELOG.md
3:All notable changes to the "dap-extension" extension will be documented in this file.
dap-estgi-vscode-extension/README.md
1:# dap-extension README
dap/session/Main.hs
91:-- > "type": "dap-extension"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.