fromBytes throws exceptions instead of returning the error inside the Maybe ValidationFailure

[jship]

The following program throws a ByteOutOfBound exception instead of providing the error in the Maybe ValidationError in the triple returned by fromBytes.

#!/usr/bin/env stack
-- stack script --resolver lts-8.17 --package foundation
{-# LANGUAGE NoImplicitPrelude #-}
{-# LANGUAGE OverloadedStrings #-}
module Main where

import Control.Monad
import Foundation
import Foundation.String
import Foundation.String.ASCII
import Foreign.C.Types

printString :: Encoding -> UArray Word8 -> IO ()
printString enc bytes = do
  -- fromBytes :: Encoding -> UArray Word8 -> (String, Maybe ValidationFailure, UArray Word8)
  let (string, minvalid, rest) = fromBytes enc bytes
  putStrLn string
  case minvalid of
    Nothing -> putStrLn "Valid!"
    (Just vf) -> putStrLn "Invalid!"
  when (null rest) $ do
    putStrLn "rest is empty"
  unless (null rest) $ do
    putStrLn "rest is not empty"

main = printString ASCII7 (fromList [0xff])

strings: ByteOutOfBound 255

[NicolasDP]

@jship, is it a bug you are happy to look at ?

[jship]

Yes, will take a look at it.

[jship]

@NicolasDP: Can think of a few options to this and would like to discuss with you.

1. Do something similar to what UTF8 does with its validate function. UTF8 doesn't use the fromEncodeBytes machinery.
2. Update Builder itself to wrap an error transformer.
3. Update builderBuild to no longer discard the monadic result and return possible error there.

Interested in pairing on this today with myself and @Tiltman?

[NicolasDP]

I think you are looking at the right solution. We could try some stuff with the Builder

We can extend it with MonadThrow and MonadCatch. This will allow us to do some error handling/reporting in convertFromTo and the Encoding .encodingWrite specialised function.