Update upper bounds + compile tweaks #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tToJSON`. GenVal newtype for directing QC
|
let me know if you'd like me to squash the commits |
|
Sorry I hadn't seen this! GitHub either didn't send me a notification or it got lost in my mailbox. Either way, these changes look good. Will just wait for CI and if everything is green, merge. |
|
I've pulled your changes into #4 and adjusted CI. |
goodlyrottenapple
added a commit
that referenced
this pull request
May 19, 2023
some new upper bounds, patch for newer Aeson, compile fix to exclude whatever weird QC generator for Values was emitting strings with embedded NULs, and a minor tweak to the roundtrip property so counterexamples get printed Courtesy of mwotton's original PR: #2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some new upper bounds, patch for newer Aeson, compile fix to exclude whatever weird QC generator for Values was emitting strings with embedded NULs, and a minor tweak to the roundtrip property so counterexamples get printed