Authentication for GitHub Apps #361
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing this in favour of #365, I'll be implementing GitHub Apps support in a separate package for API previews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to authenticate as a GitHub App and create an access token for an installation of the app.
Authenticating as a GitHub App uses a JWT instead of the usual OAuth tokens. Since the JWT can't be used for authentication on normal endpoints, I've created a separate type
AppAuthso that the function type signatures can distinguish which authentication method is required.I'm not sure what the policy is on implementing API previews since the APIs aren't stable. If the
githubpackage is only for the stable parts of the API, I might look into implementing some of the API previews as a separate package and features moved across togithubas they become stable. I can separate theAuthMethodtype class changes here into a new PR as that would allow alternative auth methods such as JWTs to be implemented in a separate package.