Escape URI paths #404
Merged
Escape URI paths #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domenkozar
reviewed
Sep 29, 2019
src/GitHub/Request.hs
Outdated
| import Data.Aeson (eitherDecode) | ||
| <<<<<<< Updated upstream | ||
| import Data.List (find) | ||
| ======= |
|
I haven't tested it, but I'm using the same function to pass the path, so it should work. |
phadej
force-pushed
the
escape-paths
branch
from
898e718 to
4009572
Compare
phadej
force-pushed
the
escape-paths
branch
from
ac85b89 to
a40db0d
Compare
domenkozar
approved these changes
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #398
ping @domenkozar, does this works for your use case?