Skip to content

Conversation

andreasabel
Copy link
Member

@andreasabel andreasabel commented May 9, 2025

Reverts #521

CI reports build failures with GHC 9.0 and below:


[93 of 94] Compiling GitHub.Request   ( src/GitHub/Request.hs, /__w/github/github/dist-newstyle/build/x86_64-linux/ghc-8.2.2/github-0.29.1/noopt/build/GitHub/Request.o )

src/GitHub/Request.hs:503:36: error:
    Not in scope: ‘BS.toStrict’
    Perhaps you meant ‘LBS.toStrict’ (imported from Data.ByteString.Lazy)
    Module ‘Data.ByteString’ does not export ‘toStrict’.
    |
503 |           (\page -> ("page", Just (BS.toStrict $ toLazyByteString $ intDec page))) <$> pageParamsPage pp
    |                                    ^^^^^^^^^^^

src/GitHub/Request.hs:504:45: error:
    Not in scope: ‘BS.toStrict’
    Perhaps you meant ‘LBS.toStrict’ (imported from Data.ByteString.Lazy)
    Module ‘Data.ByteString’ does not export ‘toStrict’.
    |
504 |           , (\perPage -> ("per_page", Just (BS.toStrict $ toLazyByteString $ intDec perPage))) <$> pageParamsPerPage pp
    |                                             ^^^^^^^^^^^

Following the suggestions fixes the problem (haskell/bytestring#281).

@andreasabel andreasabel mentioned this pull request May 9, 2025
@andreasabel andreasabel added this to the 0.30 milestone May 9, 2025
@andreasabel andreasabel merged commit c54e7d6 into master May 9, 2025
13 checks passed
@andreasabel andreasabel deleted the revert-521-revert-503-per-page-query-v2 branch May 9, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant