Make examples programs #169
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a weird thing where top-level
examples
dir symlinked into tests, we used the test suite to compile the examples, and then used the doctests to check the examples worked.At least one side effect of this is we get cabal warnings all the time:
I've made the examples executables, which means they can be edited & run, which I think is a nice property. This lets us remove the symlink & doctest hackery.
In order to preserve the doctest coverage, I've translated the doctests into end-to-end tests. I think this has been a useful exercise, because it already demonstrates that our input object support / documentation is lacking (see comment on
DogStuff
).It also paves the way for a ratcheted test coverage thing, which I'm quite keen to try.