Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mtl-2.3 #60

Merged
merged 3 commits into from
May 10, 2022
Merged

Support mtl-2.3 #60

merged 3 commits into from
May 10, 2022

Conversation

sjakobi
Copy link
Collaborator

@sjakobi sjakobi commented May 7, 2022

src/Util.hs Show resolved Hide resolved
cabal.haskell-ci Show resolved Hide resolved
@sjakobi sjakobi changed the title [WIP] Support mtl-2.3 Support mtl-2.3 May 10, 2022
@sjakobi sjakobi marked this pull request as ready for review May 10, 2022 10:27
src/Util.hs Show resolved Hide resolved
HsYAML.cabal Outdated
, parsec >=3.1.13.0 && < 3.2
, transformers <0.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this is warranted by haskell/mtl#117. If you prefer releasing quickly, would you mind adding a lower bound? transformers >= 0.4 is needed for ExceptT, AFAICS.

cabal.haskell-ci Show resolved Hide resolved
@andreasabel
Copy link
Member

Please add lb for transformers. I fear @hvr's wrath if not all dependencies have lower and upper bounds. ;-)

@andreasabel andreasabel self-assigned this May 10, 2022
@andreasabel andreasabel merged commit 7e48473 into haskell-hvr:master May 10, 2022
@andreasabel
Copy link
Member

@sjakobi : I invited you to collaborate. If you accept, I can also add you to the hackage uploaders.
I do not have much interest in HsYAML myself, but it is relevant to e.g. haskell-ci and cabal-dev-scripts (in GHC and cabal). So it is needed still by the community.

@andreasabel andreasabel added this to the 0.2.1.1 milestone May 11, 2022
@andreasabel
Copy link
Member

Released as 0.2.1.1

@sjakobi sjakobi deleted the mtl-2.3 branch May 11, 2022 10:34
@sjakobi
Copy link
Collaborator Author

sjakobi commented May 11, 2022

Thanks for the invitation and the release, @andreasabel! :) I have accepted the invitation.

For now, I'm not planning on doing very much in this repo. But since dhall-yaml depends on HsYAML I have an interest in keeping the lights on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants