Strict拡張を使用する際の注意点 #168

igrep · 2019-09-01T13:50:16Z

Fix: #167

examples/strict-gotchas/tuple.hs

#168 (comment)

examples/strict-gotchas/storable.hs

igrep · 2019-09-07T12:03:43Z

✍️ あとexampleでやるべきは

foldl の例をもう少し整える（勧められたとおり、スタックサイズを減らして試してみる）
「BangPattern をつけてはいけないところは， Strict 拡張でも lazy を明示的に指定しなくてはいけないので，ここら辺も NoStrict の時と注意点が同じと言う感じですね」の例
~~f x = g (h x) と f = g . h の比較~~ より単純に、 const を使った例にしました。
記事のパスとそろえるために examples/2019/ 以下に移す

igrep · 2019-09-23T09:58:31Z

exampleはここまでで、そろそろ本文に取りかかろう

igrep · 2019-11-30T00:52:15Z

📝 メモ: おまけで紹介したい: https://github.com/ndmitchell/spaceleak

#168 (comment)

I mistook the reason why (error Error in MyTuple2) is called: it is because MyTuple is strict in its arguments, not because the pattern matching is strict #167 (comment)

#168 (comment)

Finding better example was hard...

「BangPattern をつけてはいけないところは， Strict 拡張でも lazy を明示的に指定しなくてはいけないので，ここら辺も NoStrict の時と注意点が同じと言う感じですね」の例としてfoldrの例を分ける

…chas

#168 (comment)

igrep · 2020-06-07T04:26:54Z

@mizunashi-mana @minoki 大変長らくお待たせしました。ようやくWIPを外したのでお手すきの際にレビューいただきたく！ 🙏

Just to move the article to the top of the article list. I'm not sure when it'll really be published!

mizunashi-mana · 2020-06-07T04:56:45Z

IMO: 好みの問題だと思いますが，一文一文が頻繁に改行されていると，一々目線を先頭に持っていかなければいけなくてとても読みづらいので，パラグラフは改行なしでまとまっている方が良いと思いました

igrep · 2020-06-07T05:07:16Z

なるほど。個人的には改行するのを好んでやってたので、悩ましいですね... 😕

igrep · 2020-06-07T05:25:34Z

試しにすべての改行を消してみました。
vimで機械的にやったのでどこか壊れているかも知れませんが取り急ぎ。

mizunashi-mana

いくつかコメントしました．

なお，個人的には Strict 拡張は有効にすべき派で，理由としてはこれらのミスより Strict を有効にしない場合に bang を書き忘れて起こるスペースリークの方がはるかに致命的な場合が多いからですね

preprocessed-site/posts/2020/strict-gotchas.md

igrep · 2020-06-07T10:31:46Z

個人的には Strict 拡張は有効にすべき派で，理由としてはこれらのミスより Strict を有効にしない場合に bang を書き忘れて起こるスペースリークの方がはるかに致命的な場合が多いからですね

それは別途気になるのでいつか記事にしていただけるとありがたいです！ 🙏

igrep · 2020-06-10T00:31:36Z

@mizunashi-mana @minoki 一通り直せたはずです。
ありがとうございます！

Update the date to publish Fix link to `StrictData` Set the link to the section of case 2 Add note about my point of view And several other update of expressions

mizunashi-mana

幾つかコメントしました

preprocessed-site/posts/2020/strict-gotchas.md

igrep · 2020-06-11T00:56:41Z

@minoki @mizunashi-mana 直しました！ ✅

minoki · 2020-06-11T01:25:15Z

私の見た感じでは、公開しても問題ないレベルに達したと思います。

mizunashi-mana

LGTM

igrep · 2020-06-11T10:48:19Z

ありがとうございました！最終確認が終わったのでマージします！

igrep mentioned this pull request Sep 1, 2019

[Topic Request] Strict拡張を使用する際の注意点 #167

Closed

mizunashi-mana reviewed Sep 1, 2019

View reviewed changes

examples/strict-gotchas/tuple.hs Outdated Show resolved Hide resolved

igrep added a commit that referenced this pull request Sep 1, 2019

Delete misleading example

ac73dca

#168 (comment)

fumieval reviewed Sep 2, 2019

View reviewed changes

examples/strict-gotchas/storable.hs Outdated Show resolved Hide resolved

igrep added a commit that referenced this pull request Jan 7, 2020

Delete misleading example

e230a86

#168 (comment)

igrep force-pushed the strict-gotchas branch from a14c785 to f4b155c Compare January 7, 2020 13:20

igrep added a commit that referenced this pull request Apr 12, 2020

Delete misleading example

64173e9

#168 (comment)

igrep force-pushed the strict-gotchas branch from 2a62ad2 to 02882a1 Compare April 12, 2020 12:50

igrep added 19 commits June 7, 2020 12:53

(WIP) Add examples for #167

caabe89

Add readme for example

3f6c3f1

Fix: misleading example

4d503eb

I mistook the reason why (error Error in MyTuple2) is called: it is because MyTuple is strict in its arguments, not because the pattern matching is strict #167 (comment)

Delete misleading example

21c5e69

#168 (comment)

Delete unused function

e23a69e

Add comment

96e4e90

(WIP) Add example for foldr/foldl

310b2a2

Give same condition to foldr

d533cda

Complete example of storable.hs

1fe0ebd

Finding better example was hard...

Rewrite example of foldl

ab59806

Correct path to stackoverflow.hs

12644b7

Complete example of stackoverflow.hs

3dfa717

Add example to compare when referring arguments or not

c3988e2

Reorganize .gitignore

adac611

Split out the foldr example

a459f49

「BangPattern をつけてはいけないところは， Strict 拡張でも lazy を明示的に指定しなくてはいけないので，ここら辺も NoStrict の時と注意点が同じと言う感じですね」の例としてfoldrの例を分ける

Move the example directory into the same path with article

93cd8e2

Begin to write strict-gotchas.md

358bce5

I want to finish this article in the end of this month!

ef3963a

WIP. SAMPLE CODE NOT TESTED AFTER UPDATING stack.yaml: Add strict-got…

1fa0f30

…chas

Fix minor expressions, add the bottom line

ffadf6f

igrep force-pushed the strict-gotchas branch from b3ead0d to ffadf6f Compare June 7, 2020 03:54

igrep changed the title ~~[WIP] Strict拡張を使用する際の注意点~~ Strict拡張を使用する際の注意点 Jun 7, 2020

Refer to https://github.com/ndmitchell/spaceleak

ee31c10

#168 (comment)

Update the date to publish

aa06f3d

Just to move the article to the top of the article list. I'm not sure when it'll really be published!

Concatenate all lines in a paragraph

020ed49

mizunashi-mana requested changes Jun 7, 2020

View reviewed changes

preprocessed-site/posts/2020/strict-gotchas.md Outdated Show resolved Hide resolved

preprocessed-site/posts/2020/strict-gotchas.md Outdated Show resolved Hide resolved

minoki reviewed Jun 7, 2020

View reviewed changes

preprocessed-site/posts/2020/strict-gotchas.md Outdated Show resolved Hide resolved

minoki reviewed Jun 7, 2020

View reviewed changes

preprocessed-site/posts/2020/strict-gotchas.md Outdated Show resolved Hide resolved

igrep added 2 commits June 7, 2020 15:40

Fix typo

a640090

Add an article about BangPatterns to the reading list

e021141

Rewrite case of tuple, plus some minor updates

87802ce

igrep requested a review from mizunashi-mana June 10, 2020 00:31

Minor updates:

fcd35da

Update the date to publish Fix link to `StrictData` Set the link to the section of case 2 Add note about my point of view And several other update of expressions

mizunashi-mana reviewed Jun 10, 2020

View reviewed changes

preprocessed-site/posts/2020/strict-gotchas.md Outdated Show resolved Hide resolved

preprocessed-site/posts/2020/strict-gotchas.md Outdated Show resolved Hide resolved

preprocessed-site/posts/2020/strict-gotchas.md Outdated Show resolved Hide resolved

igrep added 3 commits June 11, 2020 09:40

Delete an article which might not be correct from the reading list

2dc013d

Use Japanese word

e4aaa92

Delete unnecessary = 0, fix markdown syntax issue

40e54c2

mizunashi-mana approved these changes Jun 11, 2020

View reviewed changes

igrep merged commit e0b4233 into master Jun 11, 2020

igrep deleted the strict-gotchas branch June 11, 2020 10:48

Strict拡張を使用する際の注意点 #168

Strict拡張を使用する際の注意点 #168

Uh oh!

Conversation

igrep commented Sep 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

igrep commented Sep 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

igrep commented Sep 23, 2019

Uh oh!

igrep commented Nov 30, 2019

Uh oh!

igrep commented Jun 7, 2020

Uh oh!

mizunashi-mana commented Jun 7, 2020

Uh oh!

igrep commented Jun 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

igrep commented Jun 7, 2020

Uh oh!

mizunashi-mana left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

igrep commented Jun 7, 2020

Uh oh!

igrep commented Jun 10, 2020

Uh oh!

mizunashi-mana left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

igrep commented Jun 11, 2020

Uh oh!

minoki commented Jun 11, 2020

Uh oh!

mizunashi-mana left a comment

Choose a reason for hiding this comment

Uh oh!

igrep commented Jun 11, 2020

Uh oh!

Uh oh!

igrep commented Sep 1, 2019 •

edited

Loading

igrep commented Sep 7, 2019 •

edited

Loading

igrep commented Jun 7, 2020 •

edited

Loading