compile the code snippets in tutorial/api-type.(md/lhs) #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| set -o errexit | ||
|
|
||
| cabal exec -- ghc -outputdir build-output ../tutorial/api-type.lhs |
There was a problem hiding this comment.
I imagine you know the other files still need to be added?
|
I realize that in the tutorial there's lots of code quoted from the |
soenkehahn
force-pushed
the
compile-examples
branch
from
7592918 to
721b173
Compare
soenkehahn
force-pushed
the
compile-examples
branch
from
721b173 to
b647f44
Compare
soenkehahn
force-pushed
the
compile-examples
branch
from
c13eea6 to
0915d16
Compare
|
I'm wondering whether all imports in the tutorial should have explicit import lists. Any opinions? (@jkarni, @alpmestan, @fizruk) |
|
I'd say so, but we can do that as part of the 0.5 rewrite (or separately altogether) rather than as part of this. |
|
I am not strongly inclined to having explicit imports. |
|
+1, let's worry about that later. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still working on converting all the files. The testing machinery is ready for review.