Skip to content

Invalid requests with query flags #19

@fierce-katie

Description

@fierce-katie

We've recently encountered a couple of issues when generating Vanilla JS code.

Firstly, when a query flag is followed by something else, the generated request looks like this:

... + '&flag'&param=' + encodeURIComponent(param) ...

Instead of:

... + '&flag' + '&param=' + encodeURIComponent(param) ...

It is related to #11 and is even mentioned in a comment there. This part is easy to fix and I can propose a PR for it.

The second issue is that query flags are always added to the request (see valid code above), the actual argument of the client function is not even checked. This one is similar to #16, but I think it's better to have a separate issue for query flags processing.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions