Add (basic) API docs for ServerT #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isomorpheme
changed the title
gdeest
approved these changes
Apr 19, 2022
|
Thanks ! It looks reasonable. |
gdeest
approved these changes
Apr 19, 2022
|
Is there something still blocking this I can fix? The CI failure looks like a fluke. |
|
Agreed, let's get this merged. |
tchoutri
approved these changes
Jan 9, 2023
|
@isomorpheme Thank you for your patience 🙏 |
|
Thank you! |
Merged
|
This is now released on Hackage as part of servant-0.20. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reading the docs I was a bit surprised that
ServerT apiisn't a monad transformer, while I was assuming that it was due to the name. I saw #340, but since there seems to be no consensus on what it should be renamed to, I figured some clarification in a doc comment would help in the meantime.