Skip to content

Conversation

MangoIV
Copy link
Contributor

@MangoIV MangoIV commented Nov 14, 2022

Submitter checklist

I have updated the instances to also contain an instance for Void, I have not included a note in the CHANGELOG.md because I think that it's much more a fix of a missing instance than a feature addition. If you like me to also add it to the CHANGELOG, just tell me.

Copy link
Collaborator

@Kleidukos Kleidukos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, and thank you for this contribution!

2 things:

  1. It seems that your editor has taken upon itself to reformat the codebase. We abide by the CI and Fourmolu to do that. Especially, the ImportQualifiedPost extension is not supported by some of the versions of GHC tested in CI.

  2. Yes I'd very much prefer that you include it in the changelog :)

@MangoIV
Copy link
Contributor Author

MangoIV commented Nov 14, 2022

I formatted it according to the fourmolu.yaml (see the second commit)
I'll add the addition to the CHANGELOG.md

@MangoIV
Copy link
Contributor Author

MangoIV commented Nov 14, 2022

Ah I know why that happened; I have a big fourmolu command I run over all my files and that has -XImpirtQualifiedPost; however, the formatting seems not to be up to date on main, anyhow.

@MangoIV
Copy link
Contributor Author

MangoIV commented Nov 14, 2022

sorry for the fuzz.

@Kleidukos
Copy link
Collaborator

@MangoIV could you please rebase your PR on main? :)

@MangoIV
Copy link
Contributor Author

MangoIV commented Nov 15, 2022

done 👍

Copy link
Collaborator

@Kleidukos Kleidukos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Thank you very much for this addition :)

@Kleidukos Kleidukos merged commit fd69850 into haskell-text:main Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants