Skip to content

Add support for base-4.6 (ghc-7.6) #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Add support for base-4.6 (ghc-7.6) #27

wants to merge 3 commits into from

Conversation

bitc
Copy link

@bitc bitc commented Aug 13, 2012

HTTP currently does not build with base-4.6, which is to be included with ghc-7.6

The problem is that Prelude.catch was removed from base: it is now required to use Control.Exception.catch.

This pull request replaces all uses of Prelude.catch with Control.Exception.catch (thanks to https://github.com/hesselink/HTTP/tree/feature/new-exceptions) , and bumps the upper bound dependency of base to < 4.7

This probably breaks compatibility with old versions of base(3 and below), so some further preprocessor magic may be necessary.

@hsenag
Copy link
Member

hsenag commented Aug 20, 2012

Thanks for the fixes. Do they build for you? With GHC 7.6.RC1, I'm getting a problem with the auto-generated Paths_HTTP trying to use catch from the Prelude, which is odd since presumably Cabal should be responsible for that and I've got the Cabal that comes with GHC.

@hsenag
Copy link
Member

hsenag commented Aug 20, 2012

Never mind, turned out it's cabal-install responsible for that and I had an old version.

@hsenag
Copy link
Member

hsenag commented Aug 20, 2012

OK, so GHC 6.10 at least will require preprocessor magic. I'll see if the proposal on ghc-users to make hiding a non-existent import is going to go into 7.6 before deciding what to do.

@hsenag
Copy link
Member

hsenag commented Aug 31, 2012

I've applied the base bump independently and released HTTP 4000.2.4.

I still can't get the test harness to build on GHC 7.6 (because of dependencies not being updated) so haven't yet updated that to claim 7.6 support.

Thanks for getting the ball rolling!

@hsenag hsenag closed this Aug 31, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants