EventDuration: Make it more robust to truncated eventlogs #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
But aren't we lying? Perhaps warnings on |
|
@Mikolaj I wouldn't say we are lying per se. However, we could indeed print a warning. I'll do so. |
bgamari
force-pushed
the
wip/truncation-robustness
branch
from
1ca6509 to
952dcbc
Compare
Previously this would throw an exception in the (not uncommon) case of a truncated eventlog. Now we simply declare the thread to stop running at the time of the last event that we saw.
bgamari
force-pushed
the
wip/truncation-robustness
branch
from
952dcbc to
630a4f7
Compare
|
Haven't tested, but LGTM. |
|
This PR slipped under my rader somehow. Sorry. I’ll take a look tonight. |
|
Ah I just remembered the context. I did recognize this and found AppVeyor was failing for some reason. It seemed this PR was innocent though. Anyway I’ll take a look again tonight. |
|
LGTM. The AppVeyor are failing when installing library dependencies with pacman so this PR is not responsible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this would throw an exception in the (not uncommon) case of a
truncated eventlog. Now we simply declare the thread to stop running at
the time of the last event that we saw.