Skip to content

Resolve #2593: Lift global database restrictions #2617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2015

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented May 29, 2015

I'm not sure whether cabal-install should really check that we have recent enough GHC.

I tried this shortly with composition package, cabal repl session:

λ *Data.Composition > let x f g = f .: g
λ *Data.Composition > :t x
x :: (c -> d) -> (a -> b -> c) -> a -> b -> d
λ *Data.Composition > :t String

<interactive>:1:1: Not in scope: data constructor ‘String’

@dcoutts
Copy link
Contributor

dcoutts commented May 30, 2015

Yeah, I think it should check the ghc version, otherwise it still fails in an unpleasent way on older ghc.

@phadej
Copy link
Collaborator Author

phadej commented May 30, 2015

I'll add the check, I'll believe trac that the functionality is supported from GHC 7.6.1 and up.

@dcoutts
Copy link
Contributor

dcoutts commented May 30, 2015

Cheers.

@dcoutts
Copy link
Contributor

dcoutts commented May 31, 2015

Great. We'll also need to change the conversion of the db stack into ghc/ghc-pkg flags, as it has the same restriction. We've got someone at ZuriHac working on that now, so we can combine those and commit them together.

@phadej
Copy link
Collaborator Author

phadej commented May 31, 2015

👍

@snoyberg
Copy link
Collaborator

LGTM, and would be very nice to have.

@23Skidoo
Copy link
Member

Looks good, so I see no reason not to merge. The second part can be done later.

23Skidoo added a commit that referenced this pull request Aug 17, 2015
Resolve #2593: Lift global database restrictions
@23Skidoo 23Skidoo merged commit 97f292a into haskell:master Aug 17, 2015
@snoyberg
Copy link
Collaborator

Awesome, thanks @23Skidoo!

@snoyberg
Copy link
Collaborator

And of course thanks @phadej for writing it :)

@23Skidoo
Copy link
Member

Opened #2772 for the remaining part.

@snoyberg Thanks for the heads-up!

@phadej phadej deleted the no-global-db branch August 17, 2015 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants