Fix GHC version bound in CPP #57
Conversation
|
We shouldn't have CPP referring to unstable branches of GHC in the source. So you should do the thing Ben mentioned in the other PR. |
|
Well, since the current HEAD version is still |
|
If it's in the GitLab mirror then your MR can validate, right? |
Yep, CI is green there. If you've got a minute, could you possibly review it too? It's a |
|
FWIW, I wouldn't mind if this PR is closed. I'm just somewhat confused about the workflow of cross-submodule changes. |
|
@sjakobi, OK, closing (which I planned to do anyway). Sorry, I know GHC's submodule usage is a bit weird. |
Libraries email: https://mail.haskell.org/pipermail/libraries/2018-April/028724.html GHC issue: https://gitlab.haskell.org/ghc/ghc/issues/15028 Corresponding PRs for deepseq: * haskell/deepseq#55 * haskell/deepseq#57 Bumps the deepseq submodule.
|
Re-opening, based on the discussion in https://gitlab.haskell.org/ghc/ghc/-/merge_requests/3388#note_291686. |
sjakobi
force-pushed
the
wip/sjakobi/ghc-mr-3388
branch
from
0ade68f to
a169feb
Compare
|
Re-pushed since there were some CI failures. |
|
Ping @chessai. |
|
Cheers! :) |
Libraries email: https://mail.haskell.org/pipermail/libraries/2018-April/028724.html GHC issue: https://gitlab.haskell.org/ghc/ghc/issues/15028 Corresponding PRs for deepseq: * haskell/deepseq#55 * haskell/deepseq#57 Bumps the deepseq submodule.
Libraries email: https://mail.haskell.org/pipermail/libraries/2018-April/028724.html GHC issue: https://gitlab.haskell.org/ghc/ghc/issues/15028 Corresponding PRs for deepseq: * haskell/deepseq#55 * haskell/deepseq#57 Bumps the deepseq submodule.
Libraries email: https://mail.haskell.org/pipermail/libraries/2018-April/028724.html GHC issue: https://gitlab.haskell.org/ghc/ghc/issues/15028 Corresponding PRs for deepseq: * haskell/deepseq#55 * haskell/deepseq#57 Bumps the deepseq submodule.
Libraries email: https://mail.haskell.org/pipermail/libraries/2018-April/028724.html GHC issue: https://gitlab.haskell.org/ghc/ghc/issues/15028 Corresponding PRs for deepseq: * haskell/deepseq#55 * haskell/deepseq#57 Bumps the deepseq submodule.
Libraries email: https://mail.haskell.org/pipermail/libraries/2018-April/028724.html GHC issue: https://gitlab.haskell.org/ghc/ghc/issues/15028 Corresponding PRs for deepseq: * haskell/deepseq#55 * haskell/deepseq#57 Bumps the deepseq submodule. (cherry picked from commit a90d130)
Context: https://gitlab.haskell.org/ghc/ghc/-/merge_requests/3388