Skip to content

Add .dockerignore file #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Add .dockerignore file #100

merged 1 commit into from
Feb 15, 2023

Conversation

tarleb
Copy link
Collaborator

@tarleb tarleb commented Feb 14, 2023

Reduces the build context from megabytes to kilobytes.

@tarleb
Copy link
Collaborator Author

tarleb commented Feb 14, 2023

I don't think this matters here, as the build context is small anyway, so the speedup is minimal.

Copy link
Contributor

@AlistairB AlistairB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool idea! I think actually this can just be * as the whole file. I think you only need files / directories in the context if they are being added into the image somehow. With just * it still seems to work fine.

Reduces the build context from megabytes to kilobytes.
@tarleb
Copy link
Collaborator Author

tarleb commented Feb 15, 2023

Ah, true! I'm so used to needing subfolders in the context that I didn't think of that. 🤦‍♂️

Copy link
Contributor

@AlistairB AlistairB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AlistairB AlistairB merged commit b1170e2 into haskell:master Feb 15, 2023
@tarleb tarleb deleted the dockerignore branch February 15, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants