Base debian off of buildpack-deps #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is quite standard for official images and makes them more batteries included and there is a good chance this base layer will already be cached.
AlistairB
force-pushed
the
buildpack-deps
branch
from
a88e5ea to
341e1a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is quite standard for official images and makes them more batteries included.
The downside is the images increase from 2.5GB to 2.8GB ish, but I think that is worth it as the buildpack-deps base image will often be cached already due to how common it is. When the base image is cached the end user is pulling less GBs.
This also removes the
libnuma-devdependency for 9+ which as I understand it was a mistake which is fixed in9.0.2(nope not fixed in 9.0 branch) + 9.2.2.