Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

equalFilePath returns False for "/a/.." and "/" #87

Closed
yaitskov opened this issue Oct 20, 2021 · 2 comments
Closed

equalFilePath returns False for "/a/.." and "/" #87

yaitskov opened this issue Oct 20, 2021 · 2 comments
Labels
documentation

Comments

@yaitskov
Copy link

Hi,

equalFilePath doesn't take into account ".."

should be true:

equalFilePath "/" "/.."
equalFilePath "/a/../c" "/c"
@ndmitchell
Copy link
Contributor

That's not right, because of symlinks. Imagine that a is a symlink to foo/bar, then realpath /a/../c would be /foo/c which isn't equal to /c.

@ndmitchell ndmitchell mentioned this issue Oct 30, 2021
Closed
@hasufell
Copy link
Member

Maybe we should document that/why we're not doing this.

hasufell added a commit that referenced this issue Dec 2, 2021
@hasufell
Make clear that equalFilePath does not expand ".."
ceda147 
Fixes #87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hasufell @yaitskov @ndmitchell