Skip to content
This repository has been archived by the owner on Jan 2, 2021. It is now read-only.

Don't repeatedly update the progress #230

Merged
merged 1 commit into from
Dec 12, 2019
Merged

Don't repeatedly update the progress #230

merged 1 commit into from
Dec 12, 2019

Conversation

ndmitchell
Copy link
Collaborator

If you do, then VS Code keeps restarting the spinner, and it looks a bit epileptic inducing.

cocreature
cocreature approved these changes Dec 12, 2019
View reviewed changes
Copy link
Collaborator

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I somewhat liked the fact that the weird stuttering tells you that the server is still active which is why I didn’t implement this in the first place but I don’t recall it ever being useful for debugging so happy to get rid off it.

@cocreature cocreature merged commit 9d1f2ba into haskell:master Dec 12, 2019
pepeiborra pushed a commit to pepeiborra/ide that referenced this pull request Dec 29, 2020
@ndmitchell @cocreature
Don't repeatedly update the progress (haskell/ghcide#230)
03d5401
pepeiborra pushed a commit to pepeiborra/ide that referenced this pull request Dec 29, 2020
@ndmitchell @cocreature
Don't repeatedly update the progress (haskell/ghcide#230)
94b1077
pepeiborra pushed a commit to pepeiborra/ide that referenced this pull request Dec 29, 2020
@ndmitchell @cocreature
Don't repeatedly update the progress (haskell/ghcide#230)
b9f619b
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cocreature cocreature cocreature approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndmitchell @cocreature