Skip to content
This repository has been archived by the owner on Aug 3, 2024. It is now read-only.

Generate docs for orphan instances in the module where they are defined #297

Closed
ghc-mirror opened this issue May 8, 2014 · 9 comments
Closed

Comments

@ghc-mirror
Copy link

Original reporter: mail+haddock-trac@

It often happens that orphan instances are declared in an .Instances module of a package, e.g. http://hackage.haskell.org/package/vect-0.4.7/docs/Data-Vect-Double-Instances.html.

It is very impractical that Haddock generates empty pages for this.

It would be great if haddock could always generate instance documentation for orphan instances in modules are defined.

@ghc-mirror ghc-mirror self-assigned this May 8, 2014
@chowells79
Copy link

This really would be very handy.

@mgsloan
Copy link

mgsloan commented May 26, 2016

What happened with this? Is hackage using too old of a haddock?

Store has many instances, I'd expect to see them here https://hackage.haskell.org/package/store-0.1.0.1/docs/Data-Store-Internal.html or here https://hackage.haskell.org/package/store-0.1.0.1/docs/Data-Store.html

Pinging @phadej since he implemented the fix in #449

@phadej
Copy link
Contributor

phadej commented May 26, 2016

N@mgsloan seems to be in haddock bundled with ghc8: http://docs.futurice.com/haskell-mega-repo/futurice-prelude-0.1.9.0/Futurice-Prelude-Internal-Orphans.html (IIRC hackage uses GHC 7.10, and there aren't haddock with orphans for it)

@bgamari
Copy link
Collaborator

bgamari commented May 26, 2016

Oleg Grenrus notifications@github.com writes:

@mgsloan seems to be in haddock bundled with ghc8:
http://docs.futurice.com/haskell-mega-repo/futurice-prelude-0.1.9.0/Futurice-Prelude-Internal-Orphans.html

Indeed, we'll need to update the Haddock version used by the Hackage
documentation builder. @davean, how can we make this happen?

@davean
Copy link

davean commented May 26, 2016

I can take care of that, what has to happen?

On Thu, May 26, 2016 at 5:48 AM, Ben Gamari notifications@github.com
wrote:

Oleg Grenrus notifications@github.com writes:

@mgsloan seems to be in haddock bundled with ghc8:

http://docs.futurice.com/haskell-mega-repo/futurice-prelude-0.1.9.0/Futurice-Prelude-Internal-Orphans.html

Indeed, we'll need to update the Haddock version used by the Hackage
documentation builder. @davean, how can we make this happen?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#297 (comment)

@bgamari
Copy link
Collaborator

bgamari commented May 27, 2016

davean notifications@github.com writes:

I can take care of that, what has to happen?

You will need to update on the builder to GHC to 8.0.1 and ensure that
the haddock shipped with this release is used by the builder.

Cheers,

  • Ben

@bgamari
Copy link
Collaborator

bgamari commented Jun 10, 2016

Ben Gamari ben@smart-cactus.org writes:

[ Unknown signature status ]
davean notifications@github.com writes:

I can take care of that, what has to happen?

You will need to update on the builder to GHC to 8.0.1 and ensure that
the haddock shipped with this release is used by the builder.

Any news on this?

@Blaisorblade
Copy link

This (?) is hiding instances for Text from Text, because its instances are somehow technically orphans (?) (instances in Data.Text, datatype definition in Data.Text.Internal):
http://hackage.haskell.org/package/text-1.2.2.1/docs/Data-Text.html#g:4

@phadej
Copy link
Contributor

phadej commented Aug 11, 2016

It's not this. IIRC the bug was present in haddock shipped with GHC7.10 already. Seems there aren't an issue for that though. There are similar bugs reports already

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants