Port the remains of Hi-Haddock #1571
Conversation
Kleidukos
force-pushed
the
haddock-1566-hi-haddock
branch
2 times, most recently
from
84ebfc1
to
d57fe45
Compare
haddock-api/src/Haddock/Interface.hs
Outdated
| -- TODO: Determine how to use `load'` since GHC 9.4 | ||
| load' noIfaceCache LoadAllTargets Nothing modGraph |
There was a problem hiding this comment.
@bgamari It's unclear to me how load' is supposed to be used since GHC 9.4. Could you perhaps help shed some light on its usage? The patch was originally written when load' had different arguments and I'm not sure the Nothing is a good value.
There was a problem hiding this comment.
Yes, Nothing should be fine here. This argument is intended for use by clients like GHCi which call load multiple times in succession.
There was a problem hiding this comment.
Okay!
On my end I tracked the Data.Ix exception that occurs when running the tests to something happening inside of the GHC API (but I can't really afford to insert putStrLn statements all over the GHC API.
Is this something we could pair on? I'm quite certain there must be a better way to track the origin of such an exception. :)
There was a problem hiding this comment.
For the record, this issue was due to the fact that the Haddock interface file version was not bumped. This meant that Haddock attempted to deserialize interfaces from the bootstrap compiler, which were incompatible with those expected by this branch.
|
@Kleidukos and I spent a few hours last week looking at this and nailed most of the correctness issues. What remains is to do some performance measurements to ensure that nothing has regressed horribly and do a final review of the changed testsuite results. |
* Keep track of ordered list indexes and render them * Rename some identifiers to clarify
Kleidukos
force-pushed
the
haddock-1566-hi-haddock
branch
from
86c402f
to
cceaa92
Compare
| @@ -176,12 +151,12 @@ rename dflags gre = rn | |||
| -- 'GlobalReaderEnv' during 'rename') in an appropriate doc. Currently | |||
| -- we simply monospace the identifier in most cases except when the | |||
| -- identifier is qualified: if the identifier is qualified then we can | |||
| -- still try to guess and generate anchors across modules but the | |||
| -- still try to guess and generate anchors accross modules but the | |||
No description provided.