This repository was archived by the owner on Oct 7, 2020. It is now read-only.
CI improvements #1031
Merged
CI improvements #1031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove extraneous submodules and testdata cabal files (At the time of this was added there were no submodules so I presume invalidating the cache on submodule cabal file changes is unintentional) Also sort the files so it is deterministic
lukel97
changed the title
lukel97
changed the title
alanz
reviewed
Jan 8, 2019
stack-8.2.1.yaml
Outdated
| - syz-0.2.0.0 | ||
| - yaml-0.8.32 | ||
| - github: LeastAuthority/hspec-jenkins | ||
| commit: e5ad80f176779c99fc6a8c044afc2f89ceb43103 |
There was a problem hiding this comment.
This should be a submodule, so we don't have to tweak every single config file for it. That is why we do the others that way.
|
This looks great, I have been wanting to have the junit output for a long time. Sort out the submodule and it can merge. |
|
The tags differ for 8.2.x though since the master branch has some incompatible changes with whatever version hspec is pinned to. Is there a way to go about this with submodules too?
Alternatively we could just get rid of the package and incorporate the formatter into the testutils module since it’s very small.
… On 8 Jan 2019, at 01:48, Alan Zimmerman ***@***.***> wrote:
@alanz commented on this pull request.
In stack-8.2.1.yaml:
> @@ -27,6 +27,8 @@ extra-deps:
- sorted-list-0.2.1.0
- syz-0.2.0.0
- yaml-0.8.32
+- github: LeastAuthority/hspec-jenkins
+ commit: e5ad80f176779c99fc6a8c044afc2f89ceb43103
This should be a submodule, so we don't have to tweak every single config file for it. That is why we do the others that way.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
lorenzo
approved these changes
Jan 8, 2019
alanz
reviewed
Jan 9, 2019
| , "flags: {}" | ||
| , "extra-package-dbs: []" | ||
| ] | ||
|
|
There was a problem hiding this comment.
If the block below originated elsewhere, provide details/credit.
There was a problem hiding this comment.
I had added an attribution to the fork at xmlFormatter, is this enough?
haskell-ide-engine/test/utils/TestUtils.hs
Lines 223 to 227 in fb686fa
alanz
reviewed
Jan 9, 2019
cabal.project
Outdated
| source-repository-package | ||
| type: git | ||
| location: https://github.com/LeastAuthority/hspec-jenkins | ||
| tag: 2899766bbd36216b81b1719423a5c2443458ae06 |
There was a problem hiding this comment.
I presume this is no longer needed?
|
LGTM, merge when CI passes |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all-cabal.txtfile changed every build so every job was redundantly saving the cache at the endcating soall-cabal.txtfile is now deterministic~/.hoogle~/.hoogledoesn't existA complete build on CircleCI now takes about ~20 minutes!