Skip to content
This repository was archived by the owner on Oct 7, 2020. It is now read-only.

Conversation

lukel97
Copy link
Collaborator

@lukel97 lukel97 commented Oct 18, 2018

Now that stack 1.9.1 fixes bug commercialhaskell/stack#4265

Copy link
Collaborator

@lorenzo lorenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lorenzo
Copy link
Collaborator

lorenzo commented Oct 18, 2018

I guess you will need to bust the cache for the CI builders

@lukel97
Copy link
Collaborator Author

lukel97 commented Oct 18, 2018 via email

@alanz
Copy link
Collaborator

alanz commented Oct 18, 2018

And maybe we should wait a week or two to let more people update to stack 1.9.1 first

@lukel97 lukel97 added the gardening 🌱 Small tidy-ups and maintenance label Oct 29, 2018
@lukel97
Copy link
Collaborator Author

lukel97 commented Dec 1, 2018

@alanz @lorenzo Has enough time passed to assume users are on stack 1.9 now?

@alanz
Copy link
Collaborator

alanz commented Dec 1, 2018

I would say so

@lukel97
Copy link
Collaborator Author

lukel97 commented Dec 1, 2018 via email

@iGOTCHA34
Copy link

I need to get some info about how this works and what is the BEST way to do IT

@alanz alanz modified the milestones: 2018-12, 2019-01 Dec 24, 2018
@alanz
Copy link
Collaborator

alanz commented Jan 8, 2019

LGTM, merge when the CI passes

@lukel97 lukel97 merged commit 0345d24 into haskell:master Jan 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
gardening 🌱 Small tidy-ups and maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants