This repository was archived by the owner on Oct 7, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 206
Use internal library for testing #885
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now that stack 1.9.1 fixes bug commercialhaskell/stack#4265
lorenzo
approved these changes
Oct 18, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I guess you will need to bust the cache for the CI builders |
I think we need to upgrade the stack version on the image too
… On 18 Oct 2018, at 11:02, José Lorenzo Rodríguez ***@***.***> wrote:
I guess you will need to bust the cache for the CI builders
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
And maybe we should wait a week or two to let more people update to stack 1.9.1 first |
I would say so |
We’ll need to upgrade the circle CI docker image to use stack 1.9.1.
Should it be enough to just add a `RUN stack upgrade` to the Dockerfile?
… On 1 Dec 2018, at 18:24, Alan Zimmerman ***@***.***> wrote:
I would say so
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#885 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACX4jNrNMUL_8mYJSqLOiAD1mf__4jdxks5u0slCgaJpZM4XtESk>.
|
I need to get some info about how this works and what is the BEST way to do IT |
…into internal-test-lib
LGTM, merge when the CI passes |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that stack 1.9.1 fixes bug commercialhaskell/stack#4265