Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for multi-component goto def and make runLanguageServer responsible for hiedb #1373

Merged
merged 7 commits into from Feb 15, 2021

Conversation

wz1000
Copy link
Collaborator

@wz1000 wz1000 commented Feb 15, 2021

Test for #1357

Involved re-jigging 'runWithDb' to be within the callback to 'runLanguageServer' so that the database location
is derived from the 'rootPath' of the LSP session, and not the starting CWD of the ghcide process.

I have verified that the test fails without the mentioned commit.

Copy link
Collaborator

@pepeiborra pepeiborra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner, thanks. I have but one request, can we make the location of the hiedb file configurable?

I don't have any strong opinions on how to expose it, but in case it helps the SessionLoadingOptions already allow to override the location of the cache dirs, so maybe the easiest thing to do would be to add another field in that record for the hiedb.

@wz1000
Copy link
Collaborator Author

wz1000 commented Feb 15, 2021

can we make the location of the hiedb file configurable?

@pepeiborra can I do that in another PR tomorrow?

@pepeiborra
Copy link
Collaborator

can we make the location of the hiedb file configurable?

@pepeiborra can I do that in another PR tomorrow?

Are you keen on landing this PR today?

@wz1000
Copy link
Collaborator Author

wz1000 commented Feb 15, 2021

No, its just that the other changes in this PR are necessary for making the test run.

@wz1000
Copy link
Collaborator Author

wz1000 commented Feb 15, 2021

@pepeiborra OK, I've made it configurable.

Copy link
Collaborator

@pepeiborra pepeiborra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks!

@wz1000 wz1000 added the merge me Label to trigger pull request merge label Feb 15, 2021
@mergify mergify bot merged commit 132193e into master Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants