Add a pre commit hook for code formatting #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
many thanks, agree with the exposed plan |
|
@jneira As far as there are different default extensions per directory, no |
|
wow 1100 lines of config are hard to digest for me too |
|
@jneira Yeah sure, all those comments are of the default config generator, and we have a reference link, I think it's good to go. |
Ailrun
force-pushed
the
use-pre-commit-hook
branch
from
6a492ad
to
f871fff
Compare
|
@jneira How about now? |
jneira
approved these changes
Feb 16, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves partially #693.
I will format code base after this PR. I think it's quite hard to find a time slot when there is no "big" PR, so it's maybe better to send the setting first, and format after (in time slots between big PRs), so that other big PRs can use the setting to format them by their own.