Skip to content

Conversation

kakkun61
Copy link

Use newer version of ghc-check.

@pepeiborra
Copy link
Collaborator

See also haskell/ghcide#568

@jneira
Copy link
Member

jneira commented May 30, 2020

Thanks for the pr! Some comments

  • ci stack builds are failing with:
Resolving dependencies...
cabal: Could not resolve dependencies:
[__0] trying: ghcide-0.1.0 (user goal)
[__1] trying: ghcide:-ghc-lib
[__2] next goal: ghc-check (dependency of ghcide -ghc-lib)
[__2] rejecting: ghc-check-0.4.0.0 (conflict: ghcide -ghc-lib =>
ghc-check>=0.3.0.1 && <0.4)
[__2] trying: ghc-check-0.3.0.1
[__3] next goal: haskell-language-server (user goal)
[__3] rejecting: haskell-language-server-0.1.0.0 (conflict:
ghc-check==0.3.0.1, haskell-language-server => ghc-check>=0.4)
[__3] fail (backjumping, conflict set: ghc-check, haskell-language-server)

stack-*.yaml files should be updated to use the new version

  • As pointed out by @pepeiborra the ghcide changes should be merged/rebased to leverage the new ghc-check version
    ** Not sure if actual changes improve the actual check, if it is so we could integrate those changes thereafter

@kakkun61
Copy link
Author

kakkun61 commented Jun 6, 2020

OK, I'll wait for the merging/rebasing of ghcide.

@fendor
Copy link
Collaborator

fendor commented Jun 29, 2020

This would be nice to do now.
There has been already a release of ghc-check 0.5.0.1

@kakkun61
Copy link
Author

kakkun61 commented Jul 9, 2020

ghc-check 0.5.0.1 is already supported on master.

@kakkun61 kakkun61 closed this Jul 9, 2020
@kakkun61 kakkun61 deleted the ghc-check-0.4 branch July 9, 2020 11:05
pepeiborra pushed a commit that referenced this pull request Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants