Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid always rerunning GetModificationTime for interface files too #1506

Merged
merged 5 commits into from Mar 7, 2021

Conversation

pepeiborra
Copy link
Collaborator

Extends the changes introduced in #1487 to interface files.

To verify:

[nix-shell:~/scratch/ide]$ cabal exec cabal run ghcide-bench -- -- --example-package-name Cabal --example-module Distribution/Simple.hs --example-package-version 3.0.0.0 -s "edit" --samples 1 --shake-profiling /tmp/ghcide --no-clean
Up to date
Config {verbosity = Normal, shakeProfiling = Just "/tmp/ghcide", otMemoryProfiling = Nothing, outputCSV = "results.csv", buildTool = Cabal, ghcideOptions = [], matches = ["edit"], repetitions = Just 1, ghcide = "ghcide", timeoutLsp = 60, example = GetPackage {exampleName = "Cabal", exampleModules = ["Distribution/Simple.hs"], exampleVersion = Version {versionBranch = [3,0,0,0], versionTags = []}}}
starting test
Setting up document contents took 7.18s
Running edit benchmark
0.47s
name | success | samples | startup | setup | userTime | delayedTime | totalTime
---- | ------- | ------- | ------- | ----- | -------- | ----------- | ---------
edit | True    | 1       | 8.67s   | 0.00s | 0.47s    | 0.00s       | 0.47s    
[nix-shell:~/scratch/ide]$ open /tmp/ghcide/ide-20210306-135108-00006.html 

image

@pepeiborra pepeiborra force-pushed the push-notifications-interfaces branch 2 times, most recently from 4f7d6ab to cd49ec4 Compare March 6, 2021 18:47
@pepeiborra pepeiborra requested a review from wz1000 March 7, 2021 10:03
@wz1000 wz1000 added the merge me Label to trigger pull request merge label Mar 7, 2021
@mergify mergify bot merged commit a05a842 into master Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants