Add CPP Options for Stylish Haskell & Brittany Formatters #1620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where the `stylish-haskell` & `brittany` plugins weren't being added to the enabled plugins list, even if HLS was compiled with their specific flags or the `all-formatters` flag. Also removed the AGPL flag checking when adding the `brittany` plugin, since that is no longer defined anywhere.
berberman
approved these changes
Mar 25, 2021
pepeiborra
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the
stylish-haskell&brittanypluginsweren't being added to the enabled plugins list, even if HLS was
compiled with their specific flags or the
all-formattersflag.Also removed the AGPL flag checking when adding the
brittanyplugin,since that is no longer defined anywhere.