Set TextDocumentEdit version to Nothing instead of Just 0 #1727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clients like the one built into neovim reject edits where the version is lower than the expected document version. This was always the case with hls because the version is hardcoded to 0. vscode seems to accept that, but based on the specification it is more accurate to set the version to `null` if it is not know. The `textDocument` of `TextDocumentEdit` has the type `OptionalVersionedTextDocumentIdentifier`
mfussenegger
added a commit
to mfussenegger/neovim
that referenced
this pull request
Apr 14, 2021
There were a couple of reports of "Buffer X newer than edits" problems. We first assumed that it is incorrect for a server to send 0 as a version - and stated that they should send a `null` instead, given that in the specification the `textDocument` of a `TextDocumentEdit` is a `OptionalVersionedTextDocumentIdentifier`. But it turns out that this was a change in 3.16, and in 3.15 and earlier versions of the specification it was a `VersionedTextDocumentIdentifier` and language servers didn't have a better option than sending `0` if they don't keep track of the version numbers. So this changes the version check to always accept `0` values. See - neovim#12970 - neovim#14256 - haskell/haskell-language-server#1727
|
If this is obsolete, could you please close this? |
Sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clients like the one built into neovim reject edits where the version is
lower than the expected document version.
This was always the case with hls because the version is hardcoded to 0.
vscode seems to accept that, but based on the specification it is more
accurate to set the version to
nullif it is not know.The
textDocumentofTextDocumentEdithas the typeOptionalVersionedTextDocumentIdentifierUpdate: Figured out that in 3.15 the
textDocumentwas aVersionedTextDocumentIdentifier. We merged a change in neovim to allow 0 versions as well so I guess this PR is obsolete.