Remove hls-ghc-x.y from install script and wrapper #1805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jneira
reviewed
May 7, 2021
|
|
||
| let copyCmd old new = if os == "mingw32" | ||
| then liftIO $ copyFile old new | ||
| else command [] "ln" ["-f", old, new] | ||
| copyCmd (localBin </> "haskell-language-server" <.> exe) (localBin </> minorVerExe) |
There was a problem hiding this comment.
Jumm, i think the ghc-x.y.z (minorVerExe in the code) is still needed, to have several hls versions and let the wrapper choose the correct one (the hlsBin in the wrapper code)
We should remove only the ghc-x.y
There was a problem hiding this comment.
Ah sorry you have renamed it to verExe, nvm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1728
As discussed in the issue, executables like
haskell-language-server-8.10are really confusing - they could be the symlink ofhaskell-language-server-8.10.2,haskell-language-server-8.10.3, or evenhaskell-language-server-8.10.4, but those are definitely not interchangeable. So it's time to remove them. Now running./cabal-hls-install hls-8.10.4will createhaskell-language-server-wrapper,haskell-language-server, andhaskell-language-server-8.10.4.