Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support call hierarchy on pattern matching #2129

Merged
merged 3 commits into from
Aug 27, 2021

Conversation

July541
Copy link
Collaborator

@July541 July541 commented Aug 27, 2021

This pr includes:

  1. Now we can request call hierarchy on pattern matching items.
  2. Null result should return Right Nothing, previous Right (Just []) and Left Error will all encounter internal errors while the new version(I'm not sure which one, it works will before) VSCode process the data, see Log(Remote Extension).

eg.

f 1 = 1
f 2 = 2

Request on line 2 will return empty before, but now it works as expected.

Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great follow up, as all of your recent work here, many thanks again!

Copy link
Member

@Ailrun Ailrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for the update!

@Ailrun Ailrun added the merge me Label to trigger pull request merge label Aug 27, 2021
@mergify mergify bot merged commit 6fa3e64 into haskell:master Aug 27, 2021
@July541 July541 deleted the callhierarchy-on-pattern branch August 28, 2021 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants