Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pragmas completion to pragmas plugin #2134

Merged
merged 7 commits into from Sep 3, 2021

Conversation

alexnaspo
Copy link
Contributor

  • Move the basic pragmas completion from GCHIDE to the pragmas module
  • Add closing pragmas snippet "-#}"

@alexnaspo alexnaspo closed this Aug 28, 2021
@alexnaspo alexnaspo reopened this Aug 28, 2021
@alexnaspoleap alexnaspoleap force-pushed the pragmas-completion-plugin branch 3 times, most recently from 191414f to 445a7fc Compare August 28, 2021 19:41
@jneira
Copy link
Member

jneira commented Aug 28, 2021

@alexnaspo thanks for your contribution, i think makes sense group all pragmasrelated code together. Are not tests about pragmas completion in the ghcide test suite? They should be moved too in that case

@alexnaspo
Copy link
Contributor Author

alexnaspo commented Aug 28, 2021

@alexnaspo thanks for your contribution, i think makes sense group all pragmasrelated code together. Are not tests about pragmas completion in the ghcide test suite? They should be moved too in that case

@jneira It looks like the functionality for pragmas completion is actually already tested in the pragmas plugin, rather than in the ghcdie test suite. example:

[ testCase "completes pragmas" $ runSessionWithServer pragmasPlugin testDataDir $ do
- There are no tests that i can see in ghcide that need to be moved. I have edited the tests in the plugin to reflect the new functionality of closing braces

return empty list from logic completions when opts or pragma start

fix empty list logic
@jneira jneira added the merge me Label to trigger pull request merge label Sep 1, 2021
@mergify mergify bot merged commit 98d9e74 into haskell:master Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants