Preserve dirty set and add dirtiness assertion #2279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jneira
approved these changes
Oct 17, 2021
|
There are multiple ways that this invariant could be broken, and new ones could be introduced in the future. This is usually the case with stateful invariants like this one, very difficult to characterise with tests alone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is another spinoff from #2263
We want to preserve the dirty set across builds, since cancellation means that his-graph might not get a chance to register the previous dirty set.
We also add an assertion that "clean" keys are never a cache miss, which would have detected the bug. Assertions are disabled in
-Obuilds by default, and the-fno-ignore-assertsis needed to enable them according to the GHC docs