Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hls-graph.cabal: link to actual readme #2404

Merged
merged 6 commits into from
Nov 29, 2021
Merged

hls-graph.cabal: link to actual readme #2404

merged 6 commits into from
Nov 29, 2021

Conversation

juhp
Copy link
Contributor

@juhp juhp commented Nov 26, 2021

(Though why not include the README in the package too?)

[skip ci]

Copy link
Collaborator

@pepeiborra pepeiborra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Would you mind including the readme in the package too?

@jneira
Copy link
Member

jneira commented Nov 28, 2021

@juhp would you have he chance of including the readme in the package? thanks!

@jneira
Copy link
Member

jneira commented Nov 29, 2021

@juhp would you have he chance of including the readme in the package? thanks!

done!

@jneira jneira added the merge me Label to trigger pull request merge label Nov 29, 2021
@juhp
Copy link
Contributor Author

juhp commented Nov 29, 2021

Thank you @jneira

@mergify mergify bot merged commit d56aae4 into haskell:master Nov 29, 2021
drsooch pushed a commit to drsooch/haskell-language-server that referenced this pull request Dec 3, 2021
* hls-graph.cabal: link to actual readme

* Add readme to package

Co-authored-by: Javier Neira <atreyu.bbb@gmail.com>
guibou added a commit to guibou/haskell-language-server that referenced this pull request Jan 6, 2022
Close haskell#2404.

`tcdLName` is partial for type/data families, its a record field
accessor which is not defined for all cases of the `TyClDecl` type.

Instead we use `tyClDeclLName` which will look for the name through an
indirection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants