Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the nix build #2452

Merged
merged 6 commits into from Dec 10, 2021
Merged

Fix the nix build #2452

merged 6 commits into from Dec 10, 2021

Conversation

michaelpj
Copy link
Collaborator

@michaelpj michaelpj commented Dec 8, 2021

Bumped nixpkgs, removed some unnecessary overrides, added a few newly needed ones.

Bumped nixpkgs, removed some unnecessary overrides, added a few newly
needed ones.
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fix the build and the general clean up

Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@jneira
Copy link
Member

jneira commented Dec 8, 2021

/rerun-workflow Testing

@jneira
Copy link
Member

jneira commented Dec 8, 2021

and [skip circleci]

@jneira
Copy link
Member

jneira commented Dec 8, 2021

The build is failing

ghcide> Setup: Encountered missing or private dependencies:
ghcide> hiedb ==0.4.1.*, implicit-hie-cradle >=0.3.0.5 && <0.4
error: builder for '/nix/store/jvclis9nvqxg20fs9gykhk4mijkq0kqa-ghcide-1.5.0.1.drv' failed with exit code 1;
       last 10 log lines:
       >   $, called at libraries/Cabal/Cabal/Distribution/Simple/Configure.hs:1024:20 in Cabal-3.2.1.0:Distribution.Simple.Configure
       >   configureFinalizedPackage, called at libraries/Cabal/Cabal/Distribution/Simple/Configure.hs:477:12 in Cabal-3.2.1.0:Distribution.Simple.Configure
       >   configure, called at libraries/Cabal/Cabal/Distribution/Simple.hs:625:20 in Cabal-3.2.1.0:Distribution.Simple
       >   confHook, called at libraries/Cabal/Cabal/Distribution/Simple/UserHooks.hs:65:5 in Cabal-3.2.1.0:Distribution.Simple.UserHooks
       >   configureAction, called at libraries/Cabal/Cabal/Distribution/Simple.hs:180:19 in Cabal-3.2.1.0:Distribution.Simple
       >   defaultMainHelper, called at libraries/Cabal/Cabal/Distribution/Simple.hs:116:27 in Cabal-3.2.1.0:Distribution.Simple
       >   defaultMain, called at /nix/store/4mdp8nhyfd
dh7bllbi7xszz7k9955n79-Setup.hs:2:8 in main:Main
       > Setup: Encountered missing or private dependencies:
       > hiedb ==0.4.1.*, implicit-hie-cradle >=0.3.0.5 && <0.4
       >
       For full logs, run 'nix log /nix/store/jvclis9nvqxg20fs9gykhk4mijkq0kqa-ghcide-1.5.0.1.drv'.
error: 1 dependencies of derivation '/nix/store/fi9c3v9ycww1m4h26zna9gvzh0m9b1m6-haskell-language-server-1.5.1.0.drv' failed to build
Error: Process completed with exit code 1.

flake.nix Outdated
Comment on lines 71 to 75
hiedb = hself.callCabal2nix "hiedb"
(builtins.fetchTarball {
url = "https://hackage.haskell.org/package/hiedb-0.4.1.0/hiedb-0.4.1.0.tar.gz";
sha256 = "11s7lfkd6fc3zf3kgyp3jhicbhxpn6jp0yjahl8d28hicwr2qdpi";
}) { };
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the default version of hiedb in nixpkgs is 0.4.0.0, so we still need a override here.
hiedb = hself.hiedb_0_4_1_0 should work.

@berberman
Copy link
Collaborator

Also, implicit-hie-cradle in nixpkgs is 0.5.0.0, but ghcide is using >= 0.3.0.5 && < 0.4. Is there a chance to update the bound?

@fendor
Copy link
Collaborator

fendor commented Dec 9, 2021

@berberman implicit-hie-cradle == 0.4.* are all broken (or at least untested). I think we may upgrade to 0.5 as it is just the last version of 0.3.*, but feels a bit pointless.

@michaelpj
Copy link
Collaborator Author

Hmm, guess I was working off an old master.

@michaelpj
Copy link
Collaborator Author

Okay, I guess I'll have to fetch in the old version of implicit-hie-cradle then, since it isn't in nixpkgs.

@Anton-Latukha
Copy link
Collaborator

Anton-Latukha commented Dec 9, 2021

Note: implicit-hie-cradle updates (& Nix part also) in #2342.

@michaelpj
Copy link
Collaborator Author

@jneira the circleci builds aren't going and I can't merge without them?

@jneira
Copy link
Member

jneira commented Dec 10, 2021

I changed recently the way circleci interacts with GitHub, will take a look asap

@jneira
Copy link
Member

jneira commented Dec 10, 2021

it should be fixed, the circleci build have a check per workflow now, instead per job, I think it is more maintainable now

@michaelpj michaelpj merged commit 60880eb into haskell:master Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nix build in ci fails due to primitive-extras-0.10.1 build error with ghc-9.0.1
5 participants