Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable aarch64-darwin in flake.nix #2561

Merged
merged 2 commits into from Jan 3, 2022

Conversation

Gabriella439
Copy link
Contributor

@Gabriella439 Gabriella439 commented Jan 2, 2022

Currently only GHC 8.10.7 builds on aarch64-darwin after this change

Currently only GHC 8.10.7 builds on `aarch64-darwin` after this change
@jneira jneira requested a review from michaelpj January 2, 2022 22:28
Copy link
Member

@jneira jneira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy to see you here and thanks for fix the builds for that arch 🙂
lgtm but will wait for an actual nix user review to merge

@jneira jneira requested a review from berberman January 2, 2022 22:32
Copy link
Collaborator

@berberman berberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It seems that GitHub actions don't support aarch64-darwin yet. Is there anyway to test the build?

@jneira
Copy link
Member

jneira commented Jan 3, 2022

we are building aarch64-darwin in the gitlab repo, only for ghc-8.10.7, it would be matter to change the gitlab CI config to add a job using the flake and several ghcs

build-aarch64-darwin:

but it can be done in another pr imo

@jneira jneira added the merge me Label to trigger pull request merge label Jan 3, 2022
@Anton-Latukha
Copy link
Collaborator

Anton-Latukha commented Jan 3, 2022

CircleCI builds awaited by the PR are not present at the dashboard queue.

@Anton-Latukha
Copy link
Collaborator

[skip circleci]

@mergify mergify bot merged commit ff0ccd6 into haskell:master Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants