Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix progress eval test randomly failing #2590

Merged
merged 2 commits into from Jan 15, 2022

Conversation

eddiemundo
Copy link
Collaborator

@eddiemundo eddiemundo commented Jan 15, 2022

Fixes #2578.

Took way too long to find for how simple it was. The issue was that getCodeLenses was occasionally eating progress create messages, which caused any further messages with the same progress tokens to fail.

The implemented fix is to expect progress messages up to the point of the code lens response, do whatever we need the code lens response for, then pass the currently active progress tokens to the final expect progress messages function finishing up the expectations.

The other progress tests should be fine since they don't eat messages.

Copy link
Collaborator

@pepeiborra pepeiborra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! The effort invested in fixing these subtle flaky tests often goes unnoticed so please accept my unlimited gratitude.

test/functional/Progress.hs Outdated Show resolved Hide resolved
test/functional/Progress.hs Outdated Show resolved Hide resolved
@pepeiborra pepeiborra merged commit acff2bd into haskell:master Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test suite: progress reporting (func-test)
2 participants