Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hls-pragmas-plugin requires ghcide >= 1.7 #2884

Merged
merged 5 commits into from May 2, 2022
Merged

hls-pragmas-plugin requires ghcide >= 1.7 #2884

merged 5 commits into from May 2, 2022

Conversation

Bodigrim
Copy link
Contributor

@Bodigrim Bodigrim commented May 1, 2022 •
edited by gitpod-io bot

Otherwise Development.IDE.printOutputable is not available.

@Bodigrim
hls-pragmas-plugin requires ghcide >= 1.7
2ee23e5 
Otherwise Development.IDE.printOutputable is not available
pepeiborra
pepeiborra approved these changes May 1, 2022
View reviewed changes
Copy link
Collaborator

@pepeiborra pepeiborra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again!

I have a question. How are you discovering all these incomplete dependencies? Do you have any insights on how we could improve our Hackage CI script?

@pepeiborra
Copy link
Collaborator

Hackage revision done

@Bodigrim
Copy link
Contributor Author

Bodigrim commented May 1, 2022

How are you discovering all these incomplete dependencies?

I'm building different versions of HLS from Hackage.

@pepeiborra pepeiborra enabled auto-merge (squash) May 2, 2022 07:01
@pepeiborra pepeiborra merged commit 6d319ba into master May 2, 2022
@July541 July541 mentioned this pull request May 2, 2022
Merged
sloorush pushed a commit to sloorush/haskell-language-server that referenced this pull request May 21, 2022
@Bodigrim @pepeiborra @sloorush
hls-pragmas-plugin requires ghcide >= 1.7 (haskell#2884)
4c4f3d1 
Otherwise Development.IDE.printOutputable is not available

Co-authored-by: Pepe Iborra <pepeiborra@gmail.com>
@Bodigrim Bodigrim deleted the Bodigrim-patch-3 branch July 9, 2022 10:28
hololeap pushed a commit to hololeap/haskell-language-server that referenced this pull request Aug 26, 2022
@Bodigrim @pepeiborra @hololeap
hls-pragmas-plugin requires ghcide >= 1.7 (haskell#2884)
3cd1411 
Otherwise Development.IDE.printOutputable is not available

Co-authored-by: Pepe Iborra <pepeiborra@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepeiborra pepeiborra pepeiborra approved these changes

@berberman berberman Awaiting requested review from berberman

@Ailrun Ailrun Awaiting requested review from Ailrun

@eddiemundo eddiemundo Awaiting requested review from eddiemundo eddiemundo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Bodigrim @pepeiborra