Hlint more partial functions, and Debug.Trace

[michaelpj]

Turns out that for functions which are typically imported in multiple ways, you need to list both explicitly, and you can't combine them (see the linked HLint issue). So I did that and added some more exceptions.

I also banned Debug.Trace, removing a couple of dead usages and adding exceptions for the existing (!) usages.

[wz1000]

Can we have global exceptions for traceEvent, traceEventIO, traceMarker and traceMarkerIO? These should cover some of the existing module exceptions.

[michaelpj]

Hmm, is eventlog tracing not exported from anywhere else? That's a shame.

[michaelpj]

I'm not sure if I can do that easily, I might have to switch to explicitly listing the banned functions from Debug.Trace.

[michaelpj]

I'm doing that, but in fact it doesn't let us get rid of any exceptions, since all of those modules also use non-eventlog tracing functions 🤷

[wz1000]

Maybe change those instances to use the existing log mechanism where it is easy? Perhaps a job for another time.

[michaelpj]

Yep, once the ratchet exists it's a nice TODO list for anyone who feels like it :)

[drsooch]

Is there no way to ignore whole directories? For example the test suites seem like it would be ok to allow certain partial functions

[michaelpj]

Not sure, I think it works off them module name anyway. I'm also not too bothered by it - the explicit list is not actually that long!

[drsooch]

Fair enough. Just looks tedious 😂