Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable a bunch of plugins that build with ghc 9.4 #3136

Merged
merged 12 commits into from
Sep 6, 2022
Merged

Enable a bunch of plugins that build with ghc 9.4 #3136

merged 12 commits into from
Sep 6, 2022

Conversation

pepeiborra
Copy link
Collaborator

No description provided.

@wz1000 wz1000 mentioned this pull request Sep 6, 2022
Closed
@wz1000 wz1000 marked this pull request as ready for review September 6, 2022 12:36
@wz1000 wz1000 enabled auto-merge (rebase) September 6, 2022 12:36
kokobd
kokobd approved these changes Sep 6, 2022
View reviewed changes
Copy link
Collaborator

@kokobd kokobd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. It's okay to just remove the dependency on exact print in hls-code-range-plugin.

July541
July541 approved these changes Sep 6, 2022
View reviewed changes
Copy link
Collaborator

@July541 July541 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!

@July541 July541 mentioned this pull request Sep 6, 2022
Closed
@wz1000 wz1000 merged commit 163ebfe into master Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wz1000 wz1000 wz1000 approved these changes

@July541 July541 July541 approved these changes

@kokobd kokobd kokobd approved these changes

@jneira jneira Awaiting requested review from jneira

@Anton-Latukha Anton-Latukha Awaiting requested review from Anton-Latukha

@Ailrun Ailrun Awaiting requested review from Ailrun

@eddiemundo eddiemundo Awaiting requested review from eddiemundo eddiemundo is a code owner

@berberman berberman Awaiting requested review from berberman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pepeiborra @wz1000 @July541 @kokobd @drsooch