Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor overlay composition #3323

Merged
merged 1 commit into from Nov 8, 2022
Merged

Refactor overlay composition #3323

merged 1 commit into from Nov 8, 2022

Conversation

Gabriella439
Copy link
Contributor

@Gabriella439 Gabriella439 commented Nov 7, 2022 •
edited by gitpod-io bot

… so that it's easier to add and remove overlays by creating a list of overlays to compose.

This should be a behavior-preserving change.

@Gabriella439
Refactor overlay composition
7b4440e 
… so that it's easier to add and remove overlays by creating a list
of overlays to compose.

This should be a behavior-preserving change.
guibou
guibou approved these changes Nov 8, 2022
View reviewed changes
Copy link
Collaborator

@guibou guibou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested by running a few shells and build and it works for me without any noticable behavior change.

Thank you.

@fendor fendor added the merge me Label to trigger pull request merge label Nov 8, 2022
@mergify mergify bot merged commit 5a8ccdb into haskell:master Nov 8, 2022
@Gabriella439 Gabriella439 deleted the gabriella/refactor_overlays branch November 8, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guibou guibou guibou approved these changes

@berberman berberman Awaiting requested review from berberman berberman is a code owner

@michaelpj michaelpj Awaiting requested review from michaelpj michaelpj is a code owner

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Gabriella439 @guibou @fendor