Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show lenses for TH generated instances #3531

Merged
merged 1 commit into from
Mar 19, 2023

Conversation

July541
Copy link
Collaborator

@July541 July541 commented Mar 18, 2023

Close #3319.

Long time no see!

Coming back with a minor improvement that cut off lenses for TH-generated instances.

@michaelpj You may be interested in this :)

@July541 July541 requested a review from Ailrun as a code owner March 18, 2023 17:18
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, awesome, was just thinking yesterday that we shouldnt show these lenses!

@July541
Copy link
Collaborator Author

July541 commented Mar 19, 2023

LGTM, awesome, was just thinking yesterday that we shouldnt show these instances!

The server kicked me off because of inactivation, but anyway, users will have a clear screen after the next release.

@fendor fendor added the merge me Label to trigger pull request merge label Mar 19, 2023
@mergify mergify bot merged commit b7cb765 into haskell:master Mar 19, 2023
@July541 July541 deleted the th-no-lens branch March 19, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lenses for type signatures for class methods appear even for generated classes
2 participants