Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes pragma plugin offering incorrect code actions #3673 #3674

Merged
merged 4 commits into from Jun 28, 2023
Merged

Fixes pragma plugin offering incorrect code actions #3673 #3674

merged 4 commits into from Jun 28, 2023

Conversation

joyfulmantis
Copy link
Collaborator

Fixes #3673

fendor
fendor approved these changes Jun 27, 2023
View reviewed changes
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

could we maybe create a constant in ghcide for these strings? (Assuming they come from ghcide)

@joyfulmantis
Copy link
Collaborator Author

LGTM, thanks!

could we maybe create a constant in ghcide for these strings? (Assuming they come from ghcide)

Yes, they all come from gchide, strewn throughout the code. A constant would certainly be wise. I'll add it to this pr before merging.

fendor
fendor approved these changes Jun 28, 2023
View reviewed changes
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@joyfulmantis joyfulmantis enabled auto-merge (squash) June 28, 2023 16:22
@joyfulmantis joyfulmantis merged commit e9c81e4 into haskell:master Jun 28, 2023
45 checks passed
@fendor fendor mentioned this pull request Aug 8, 2023
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fendor fendor fendor approved these changes

@berberman berberman Awaiting requested review from berberman

@Ailrun Ailrun Awaiting requested review from Ailrun

@eddiemundo eddiemundo Awaiting requested review from eddiemundo eddiemundo is a code owner

@pepeiborra pepeiborra Awaiting requested review from pepeiborra pepeiborra is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pragma plugin offering incorrect code actions
2 participants
@joyfulmantis @fendor